ref: use macos arm builders to speed up library build #3611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
reviewed
May 16, 2024
| @@ -47,12 +47,12 @@ jobs: | |||
| matrix: | |||
| include: | |||
| - target: x86_64-apple-darwin | |||
| py-platform: macosx-10_15_x86_64 | |||
| py-platform: macosx-14_0_x86_64 | |||
There was a problem hiding this comment.
Do we require >= macOS 14 now for all of sentry development? If not, I'd at least keep the intel build where it was.
Technically, there shouldn't be any problems, I noticed that even built on newer versions binaries require a lower version number of the system libraries, but still...
There was a problem hiding this comment.
the value here ~generally needs to match the platform it is built from -- it's already wrong on master :)
but yes we already require macos>=14
asottile-sentry
force-pushed
the
release-library/asottile-arm-builders
branch
from
333dd01
to
3940c38
Compare
asottile-sentry
force-pushed
the
release-library/asottile-arm-builders
branch
from
3940c38
to
ad57642
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.