ref(normalization): Add origin and event_type tags to normalization decision #3764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecision S4S processing relays run some normalization and I can't explain why. Adding these two tags should provide enough clarity: - `origin`: whether the event is coming from an internal relay. - `event_type`: the type of the event _before_ normalizing it. Could transactions created in processing relays explain it?
iambriccardo
approved these changes
Jun 26, 2024
jan-auer
added a commit
that referenced
this pull request
Jun 27, 2024
* master: chore(dynamic-sampling): Remove metrics for dsc tracking (#3766) feat(web-vitals): add support for mobile browsers (#3762) feat(profiles): Support profiler_id in context (#3714) ref(normalization): Add origin and event_type tags to normalization decision (#3764) feat(rate-limiting): Add back docs with examples on rate limiting (#3761) feat(spans): Correctly emit negative outcomes for rate limited transactions that have nested spans (#3749) ref(metrics): Remove unused sentry extra data (#3758) feat(statsd): Emit tokio runtime metrics via statsd (#3755) ref(metrics): Aggregate metrics before rate limiting (#3746) ref(cogs): Remove unused metric, revert to released usage accountant (#3756) build(cargo): Update curve25519-dalek from 4.0.0 to 4.1.3 (#3745) test(deps): Bump requests from 2.31.0 to 2.32.2 (#3752)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S4S processing relays run some normalization and I can't explain why.
Adding these two tags should provide enough clarity:
origin: whether the event is coming from an internal relay.event_type: the type of the event before normalizing it (i.e. it could be inaccurate). Could processing relays create transactions and explain it?#skip-changelog