feat(spool): Check preconditions before unspooling #3989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
changed the title
jjbayer
commented
Sep 5, 2024
| if state.memory_checker().check_memory().is_exceeded() { | ||
| // NOTE: Long-term, we should not reject the envelope here, but spool it to disk instead. | ||
| // This will be fixed with the new spool implementation. | ||
| if state.envelope_buffer().is_none() && state.memory_checker().check_memory().is_exceeded() { |
There was a problem hiding this comment.
In V2 mode, this check is harmful and can lead to unnecessary event loss.
jjbayer
added a commit
that referenced
this pull request
Sep 9, 2024
Remove the extra async message by returning the service's watch handle directly from `GlobalConfigService`'s constructor. This prepares for #3989, which subscribes the envelope buffer service to global config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the new spooler design, all envelopes go into the envelope buffer unconditionally (as long as it has capacity), but we must check memory capacity and global config readiness before unspooling:
ref: https://github.com/getsentry/team-ingest/issues/345
#skip-changelog