Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(devservices): Add relay configs #4049

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

hubertdeng123
Copy link
Member

@hubertdeng123 hubertdeng123 commented Sep 19, 2024

This adds devservices configs to the relay repo. This allows devservices to handle dependencies of relay (redis, kafka) in order to aid in a smoother development environment. This is an initial configuration that will be subject to change as time goes on.

#skip-changelog

@hubertdeng123 hubertdeng123 marked this pull request as ready for review September 20, 2024 22:41
@hubertdeng123 hubertdeng123 requested a review from a team as a code owner September 20, 2024 22:41
healthcheck:
test: redis-cli ping
kafka:
image: "confluentinc/cp-kafka:7.6.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hubertdeng123 how the redis and kafka versions will be kept in-sync with Sentry repo?
Is it all manual open/merge PRs operation?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are planning on making a shared definitions for kafka and redis to be used across Sentry services to ensure versions and other settings are kept in-sync

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, not available initially but it is something we are planning to add as we implement the logic for this.

@olksdr olksdr requested a review from a team September 23, 2024 09:41
Copy link
Member

@Dav1dde Dav1dde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the intention to be able to also just run this with docker-compose directly and devservices?

@hubertdeng123
Copy link
Member Author

Is the intention to be able to also just run this with docker-compose directly and devservices?

With devservices, because due to implementation using docker compose could cause unwanted behavior. We'll change the config file name to avoid this confusion

@hubertdeng123 hubertdeng123 merged commit 0321117 into master Sep 23, 2024
23 checks passed
@hubertdeng123 hubertdeng123 deleted the hubertdeng123/devservices-configs branch September 23, 2024 22:50
hubertdeng123 added a commit that referenced this pull request Sep 27, 2024
This adds the devservices cli tool to be used once the venv is
activated. The devservices
[configurations](#4049) are
already added to the snuba repo so you should be able to use it as soon
as you install the new cli tool.

We are also offering a binary to be used for a system installation of
devservices (installation instructions in the README
[here](https://github.com/getsentry/devservices)). However, use this at
your own risk given that we're changing things pretty constantly and
bumping/downgrading versions isn't quite as easy as pinning to a version
in the venv.

#skip-changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants