ref(replay): Run geo info normalization on the replay user #4088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
force-pushed
the
dav1d/replay-geo
branch
from
7293a50 to
c4d7e6f
Compare
Dav1dde
force-pushed
the
dav1d/replay-geo
branch
from
c4d7e6f to
d76fbde
Compare
jjbayer
approved these changes
Sep 30, 2024
| pub project_id: Option<ProjectId>, | ||
| pub organization_id: Option<u64>, | ||
| pub client_addr: Option<IpAddr>, | ||
| pub user_agent: RawUserAgentInfo<String>, |
There was a problem hiding this comment.
What does pub do on a field of a private struct?
There was a problem hiding this comment.
Just 'documentation' that these fields can be freely accessed as opposed to stuff which should only be exposed via methods.
loewenheim
reviewed
Sep 30, 2024
Dav1dde
force-pushed
the
dav1d/replay-geo
branch
from
ffddd40 to
97efb24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: getsentry/sentry#50639
Additionally refactors the normalization code a bit to bundle a lot of the arguments that are passed around in a single struct. Also updates the feature flag checks to use
should_filterinstead ofhas_featureto make it work on Proxy Relays.