Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(server): Organize project services in nested modules #4139

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

Dav1dde
Copy link
Member

@Dav1dde Dav1dde commented Oct 15, 2024

Organizing all the project_*.rs files we have in the services/ module in a module structure.

projects
├── cache.rs // <- services/project_cache.rs
├── mod.rs
├── project
│   ├── mod.rs // <- services/project.rs
│   └── state // <- services/project/state/*
│       ├── fetch_state.rs
│       ├── info.rs
│       └── mod.rs
└── source
    ├── local.rs // <- services/project_local.rs
    ├── mod.rs
    ├── redis.rs // <- services/project_redis.rs
    └── upstream.rs // <- services/project_upstream.rs

This only moves files around, no functional changes. It is a preparation to split out more of the convoluted services into smaller digestible parts. For example, the project_cache.rs module contains a lot of utility and helper types not relevant for the service itself, it should be possible to split this out eventually.

I chose projects as the base module to avoid having a project/project/ module, also I think it makes sense, it manages all projects and the nested module just represents a single project.

#skip-changelog

@Dav1dde Dav1dde requested a review from a team as a code owner October 15, 2024 07:06
@Dav1dde Dav1dde self-assigned this Oct 15, 2024
@Dav1dde Dav1dde requested a review from jjbayer October 15, 2024 07:08
@Dav1dde Dav1dde merged commit 9afb49f into master Oct 15, 2024
23 checks passed
@Dav1dde Dav1dde deleted the dav1d/project-modules branch October 15, 2024 08:06
jan-auer added a commit that referenced this pull request Oct 21, 2024
* master:
  ref(server): Move project source into the source module (#4154)
  instr(buffer): Measure envelope size (#4153)
  ref(redis): Cleanup code around Redis (#4151)
  lint: Rust 1.82 (#4150)
  chore(server): Remove native placeholders from transaction processing (#4148)
  feat(eap): Extract user IP (#4144)
  Revert "ref(buffer): remove peek" (#4146)
  ref(buffer): remove peek (#4136)
  release: 24.10.0
  build(deps): bump tonic from 0.12.2 to 0.12.3 (#4143)
  instr(projects): Log fetch failure (#4142)
  ref(otel): Disable default features for otel schema (#4141)
  ref(server): Organize project services in nested modules (#4139)
  ref(redis): Update to redis client version 0.27.4 (#4132)
  feat(redis): Implement parallel cmd execution of Redis calls (#4118)
  feat(spooler): Add metric to track serialization performance (#4135)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants