Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Replace organization id type with newtype #4159

Merged
merged 13 commits into from
Nov 12, 2024
Merged

ref: Replace organization id type with newtype #4159

merged 13 commits into from
Nov 12, 2024

Conversation

Litarnus
Copy link
Contributor

This PR introduces a OrganizationId new-type struct which replaces all old occurrences of u64 where it was applicable.

@Litarnus Litarnus marked this pull request as ready for review October 23, 2024 07:21
@Litarnus Litarnus requested a review from a team as a code owner October 23, 2024 07:21
iambriccardo
iambriccardo approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@iambriccardo iambriccardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did you make sure serialization and deserialization is the same as before?

CHANGELOG.md Outdated Show resolved Hide resolved
@Litarnus @iambriccardo
docs: add backticks to struct in Changelog
5656626 
Co-authored-by: Riccardo Busetti <riccardob36@gmail.com>
Dav1dde
Dav1dde approved these changes Oct 23, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
relay-base-schema/src/organization.rs Show resolved Hide resolved
relay-base-schema/src/organization.rs Outdated Show resolved Hide resolved
relay-base-schema/src/organization.rs Outdated Show resolved Hide resolved
relay-base-schema/src/organization.rs Outdated Show resolved Hide resolved
@Litarnus
Copy link
Contributor Author

LGTM, did you make sure serialization and deserialization is the same as before?

I've added tests to make sure it de/serialized the same as u64

@Litarnus Litarnus linked an issue Oct 24, 2024 that may be closed by this pull request
Introduce new-type for OrganizationId #4069
Closed
@Litarnus Litarnus self-assigned this Oct 30, 2024
@Litarnus Litarnus enabled auto-merge (squash) October 30, 2024 13:04
@Litarnus Litarnus disabled auto-merge October 30, 2024 13:11
@Dav1dde
Copy link
Member

Dav1dde commented Nov 11, 2024

@Litarnus 👀

@Litarnus
Merge branch 'master' into martinl/newtype-for-org-id
cb58ecb 
# Conflicts:
#	CHANGELOG.md
#	relay-metrics/src/meta/redis.rs
@Litarnus
Merge branch 'master' into martinl/newtype-for-org-id
02c7bed 
# Conflicts:
#	CHANGELOG.md
@Litarnus Litarnus merged commit 4a956e6 into master Nov 12, 2024
23 checks passed
@Litarnus Litarnus deleted the martinl/newtype-for-org-id branch November 12, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dav1dde Dav1dde Dav1dde approved these changes

@iambriccardo iambriccardo iambriccardo approved these changes

@loewenheim loewenheim loewenheim approved these changes

Assignees

@Litarnus Litarnus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce new-type for OrganizationId
4 participants
@Litarnus @Dav1dde @loewenheim @iambriccardo