Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow sample_rate to also be a float type #4181

Merged
merged 8 commits into from
Oct 30, 2024
Merged

feat: allow sample_rate to also be a float type #4181

merged 8 commits into from
Oct 30, 2024

Conversation

Litarnus
Copy link
Contributor

This PR makes the sample_rate parsing more lenient so it allows both string and float types.

The goal of this change is to mitigate bugs from SDKs which accidentally send the sample_rate field as float

@Litarnus Litarnus self-assigned this Oct 28, 2024
@Litarnus Litarnus linked an issue Oct 28, 2024 that may be closed by this pull request
Cannot parse DSC from envelope #4094
Closed
@Litarnus Litarnus marked this pull request as ready for review October 28, 2024 11:21
@Litarnus Litarnus requested a review from a team as a code owner October 28, 2024 11:21
Dav1dde
Dav1dde reviewed Oct 28, 2024
View reviewed changes
relay-sampling/src/dsc.rs Outdated Show resolved Hide resolved
jjbayer
jjbayer approved these changes Oct 28, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
Dav1dde
Dav1dde approved these changes Oct 28, 2024
View reviewed changes
relay-sampling/src/dsc.rs Outdated Show resolved Hide resolved
relay-sampling/src/dsc.rs Outdated Show resolved Hide resolved
relay-sampling/src/dsc.rs Outdated Show resolved Hide resolved
@Litarnus Litarnus added bug Something isn't working and removed bug Something isn't working labels Oct 29, 2024
@Litarnus Litarnus enabled auto-merge (squash) October 30, 2024 13:08
@Litarnus Litarnus merged commit d4467b6 into master Oct 30, 2024
23 checks passed
@Litarnus Litarnus deleted the martinl/sample-rate-leniency branch October 30, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjbayer jjbayer jjbayer approved these changes

@Dav1dde Dav1dde Dav1dde approved these changes

Assignees

@Litarnus Litarnus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot parse DSC from envelope
3 participants
@Litarnus @Dav1dde @jjbayer