ref(project-cache): Schedule evictions #4241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
force-pushed
the
dav1d/scheduled-evicitions
branch
3 times, most recently
from
1acab0c
to
cff5631
Compare
Dav1dde
changed the title
Dav1dde
force-pushed
the
dav1d/scheduled-evicitions
branch
2 times, most recently
from
c5156de
to
16ed5b8
Compare
Dav1dde
force-pushed
the
dav1d/scheduled-evicitions
branch
2 times, most recently
from
3d449f7
to
64a531c
Compare
Dav1dde
force-pushed
the
dav1d/scheduled-evicitions
branch
from
64a531c
to
ce1aafc
Compare
loewenheim
reviewed
Nov 12, 2024
jjbayer
approved these changes
Nov 12, 2024
loewenheim
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hunt for tail latencies continues.
Project cache evictions for large project caches are quite costly, we're seeing a max latency for evictions of > 50ms. Timing the evictions of each project is not just much faster (log(n) inserts instead of full scans through projects), but also much shorter individually, giving the runtime opportunities to schedule other tasks.
Implementation is largely the same as in #4233, just backed by a
PriorityQueueinstead of aBinaryHeap, the future scheduling code is shared and not changed.#skip-changelog