fix(spans): Normalize INP spans further #4298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
INP spans sets some top level span attributes inside span.data so make sure to pull them out to the top level. This has implications in the snuba consumer so that we do not redundant keys with slightly different names in span.data.
jjbayer
approved these changes
Nov 27, 2024
| // INP spans sets some top level span attributes inside span.data so make sure to pull | ||
| // them out to the top level before further processing. | ||
| if let Annotated(Some(ref mut data), _) = span.data { | ||
| if let Some(exclusive_time) = match data.other.get("sentry.exclusive_time") { |
There was a problem hiding this comment.
Could you add sentry.exclusive_time and profile_id as fields on the SpanData type? I assume a hypothetical SDK that can only send Otel spans would still send these as span attributes? Or are these legacy fields that future SDKs should not send?
There was a problem hiding this comment.
They can continue sending them as span attributes.
jjbayer
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INP spans sets some top level span attributes inside span.data so make sure to pull them out to the top level. This has implications in the snuba consumer so that we do not redundant keys with slightly different names in span.data.