-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(native): Set sdk.name for events created from minidumps #4313
feat(native): Set sdk.name for events created from minidumps #4313
Conversation
relay-server/src/utils/native.rs
Outdated
}; | ||
use relay_protocol::{Annotated, Value}; | ||
|
||
type Minidump<'a> = minidump::Minidump<'a, &'a [u8]>; | ||
|
||
/// Client SDK name used for the event payload to identify events created out of minidumps. | ||
const CLIENT_SDK_NAME: &str = "minidump"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would give this a name to indicate that it applies specifically to minidumps.
Adding the more specific names sounds like a good idea to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good if you modify existing tests to also assert the client sdk name, we should have at least some tests that can be easily extended to assert the SDK name.
…st that can be expanded
}; | ||
|
||
// Add sdk information for analytics. | ||
event.client_sdk.get_or_insert_with(|| ClientSdkInfo { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this override the SDK set in the client? Or this only affects minidumps from the minidump endpoint?
Meaning if it's sentry-native
attaching a minidump from crashpad, will it no longer send sentry-native
?
Sets the sdk.name for events created out of minidumps to
minidump
, mimicking the logic that we currently have for unreal.Not sure we can add more detail than just
minidump
? Presumably something like this could work but I am not sure if we want to do that:Fix: #4236