Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Normalize "Google Chrome" to "Chrome" #4386

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

loewenheim
Copy link
Contributor

The Chrome browser is sometimes tagged as "Google Chrome" and sometimes just "Chrome". This unifies the two into the latter.

@loewenheim loewenheim requested a review from a team as a code owner December 13, 2024 09:54
@loewenheim loewenheim self-assigned this Dec 13, 2024
@jjbayer
Copy link
Member

jjbayer commented Dec 13, 2024

Code LGTM but let's not merge this yet, there might be users that filter on Google Chrome in alerts or saved Discover queries.

@loewenheim
Copy link
Contributor Author

Code LGTM but let's not merge this yet, there might be users that filter on Google Chrome in alerts or saved Discover queries.

See the internal ticket for details on these queries.

@loewenheim loewenheim merged commit 18cc3ce into master Dec 18, 2024
23 checks passed
@loewenheim loewenheim deleted the fix/google-chrome branch December 18, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants