feat(ci): Remove cross compilation in CI, update sentry-native #4427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iambriccardo
force-pushed
the
riccardo/feat/pin-version
branch
from
451f1fe to
39e27ac
Compare
iambriccardo
changed the title
iambriccardo
changed the title
Dav1dde
approved these changes
Jan 7, 2025
.github/workflows/ci.yml
Outdated
| @@ -202,16 +202,19 @@ jobs: | |||
| echo "Running full CI" | |||
| echo 'image_names=["relay", "relay-pop"]' >> $GITHUB_OUTPUT | |||
| echo 'targets=["x86_64-unknown-linux-gnu", "aarch64-unknown-linux-gnu"]' >> $GITHUB_OUTPUT | |||
| echo 'runners=["ubuntu-20.04", "ubuntu-22.04-arm64-relay"]' >> $GITHUB_OUTPUT | |||
There was a problem hiding this comment.
Good catch! Slipped through
| @@ -301,7 +305,7 @@ jobs: | |||
| image_name: ${{ fromJson(needs.build-setup.outputs.image_names) }} | |||
|
|
|||
| env: | |||
| PLATFORMS: "${{ join(fromJSON(needs.build-setup.outputs.platforms), ',') }}" | |||
| PLATFORMS: "${{ join(fromJson(needs.build-setup.outputs.platforms), ',') }}" | |||
There was a problem hiding this comment.
According to the docs it needs to uppercase I think? https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/evaluate-expressions-in-workflows-and-actions#fromjson
But seems to work 🤷
Dav1dde
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the CI build, which began failing due to actions/runner-images#10636.
The fix involves updating the
sentry-nativesubmodule and replacing cross-compilation with regular compilation on each runner that matches the architecture being used for compilation.Closes: #3943