Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(normalization): Increase stacktrace function and symbol length limits to 512 chars #4436

Merged
merged 1 commit into from
Jan 9, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

**Features**:

- Increase stacktrace function and symbol length limits to 512 chars. ([#4436](https://github.com/getsentry/relay/pull/4436))
- Scrub non-minidump attachments if there are explicit `$attachment` rules. ([#4415](https://github.com/getsentry/relay/pull/4415))

**Internal**:
Expand Down
8 changes: 4 additions & 4 deletions relay-event-schema/src/protocol/stacktrace.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ pub struct Frame {
///
/// This function name may be shortened or demangled. If not, Sentry will demangle and shorten
/// it for some platforms. The original function name will be stored in `raw_function`.
#[metastructure(max_chars = 256, max_chars_allowance = 20)]
#[metastructure(max_chars = 512, max_chars_allowance = 20)]
#[metastructure(skip_serialization = "empty")]
pub function: Annotated<String>,

Expand All @@ -39,9 +39,9 @@ pub struct Frame {
///
/// The logic to be applied is that an intelligently trimmed function name should be stored in
/// `function` and the value before trimming is stored in this field instead. However also this
/// field will be capped at 256 characters at the moment which often means that not the entire
/// field will be capped at 512 characters at the moment which often means that not the entire
/// original value can be stored.
#[metastructure(max_chars = 256, max_chars_allowance = 20)]
#[metastructure(max_chars = 512, max_chars_allowance = 20)]
#[metastructure(skip_serialization = "empty")]
pub raw_function: Annotated<String>,

Expand All @@ -52,7 +52,7 @@ pub struct Frame {
/// like Swift, C++ or Rust.
// XXX(markus): How is this different from just storing the mangled function name in
// `function`?
#[metastructure(max_chars = 256)]
#[metastructure(max_chars = 512)]
pub symbol: Annotated<String>,

/// Name of the module the frame is contained in.
Expand Down
Loading