fix(statsd): Measure time in nanos #4495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iambriccardo
approved these changes
Feb 12, 2025
| $(.with_tag(stringify!($k), $v))* | ||
| ) | ||
| }); | ||
| $crate::metric!(timer($id) = now.elapsed() $(, $k = $v)*); |
There was a problem hiding this comment.
Is the duration here converted to ns?
There was a problem hiding this comment.
Yes, now.elapsed() is a Duration, and the macro call expands into the branch above.
Dav1dde
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of our instrumented code implicitly assumes sub-millisecond precision, but we round all timer metrics to milliseconds. This becomes a problem especially when computing the sum over a large number of sub-millisecond time frames (e.g. envelope buffer busy time).
ref: https://github.com/getsentry/team-ingest/issues/618