fix(server): Prevent multiple authentication payloads #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
force-pushed
the
fix/error-multiple-auth
branch
from
315fe0b to
be73e05
Compare
|
Verified that this works with JS SDK versions |
untitaker
approved these changes
Jun 4, 2020
See the linked commit for a short description. This was originally introduced to harden against header values bleeding across http2 connections. Today, it is useful to validate sane behavior of SDKs. |
mitsuhiko
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemements the same logic as in getsentry/sentry@96893d6: Error when multiple authentication payloads are provided, rather than taking the first one.