Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(envelope): Detect attachments that create events #609

Merged
merged 3 commits into from
Jun 8, 2020

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Jun 8, 2020

In addition to crash reports, the __sentry-event and __sentry-breadcrumb* attachments also create event payloads, and should therefore emit outcomes in Relay. This patch ensure that Item::creates_event correctly detects these, which is used in EventManager.

Changelog (Internal): Emit outcomes for event payloads submitted in attachment files.

@jan-auer jan-auer requested a review from a team June 8, 2020 07:35
@jan-auer jan-auer self-assigned this Jun 8, 2020
Copy link
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm can you update the code comment at L 446 though

AttachmentType::AppleCrashReport
| AttachmentType::Minidump
| AttachmentType::EventPayload
| AttachmentType::Breadcrumbs => true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this one

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breadcrumbs alone can also create an event payload in this code path:

return Ok(Self::event_from_attachments(
&self.config,
attachment_item,
breadcrumbs_item1,
breadcrumbs_item2,
)?);

@jan-auer jan-auer merged commit 783cfc9 into master Jun 8, 2020
@jan-auer jan-auer deleted the fix/item-creates-event branch June 8, 2020 09:34
jan-auer added a commit that referenced this pull request Jun 8, 2020
* master:
  fix(envelope): Detect attachments that create events (#609)
  ref(server): Allow formatting in the if_processing! macro (#611)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants