Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(unreal): Do not serialize broken misc_primary_cpu_brand #650

Merged
merged 3 commits into from
Jul 6, 2020
Merged

fix(unreal): Do not serialize broken misc_primary_cpu_brand #650

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a22a039
fix(unreal): Do not serialize broken misc_primary_cpu_brand
untitaker Jul 6, 2020
c8af604
approve snapshot
untitaker Jul 6, 2020
83037b0
add changelog
untitaker Jul 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions relay-server/src/utils/unreal.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,11 @@ fn merge_unreal_context(event: &mut Event, context: Unreal4Context) {
}
}

// Clear this property. It's a duplicate of misc_primary_gpu_brand and only exists because
// somebody made a typo once while mapping the GPU data from unrealcontext in symbolic, and we
// tried to fix this in a backwards-compatible way by retaining both properties.
runtime_props.misc_primary_cpu_brand = None;

if let Some(gpu_brand) = runtime_props.misc_primary_gpu_brand.take() {
let gpu_context = contexts.get_or_insert_with(GpuContext::default_key(), || {
Context::Gpu(Box::new(GpuContext::default()))
Expand Down