Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): Forward outcomes in processing mode #653

Merged
merged 5 commits into from
Jul 8, 2020
Merged

fix(server): Forward outcomes in processing mode #653

merged 5 commits into from
Jul 8, 2020

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Jul 8, 2020 •
edited
Loading

The outcome endpoint checks for emit_outcomes, which needs to return true in processing mode. This allows all components in Relay to check a single flag.

relay/relay-server/src/endpoints/outcomes.rs

Lines 8 to 10 in bc3e770

if !body.relay.internal || !state.config().emit_outcomes() {
return HttpResponse::Forbidden().finish();
}

@jan-auer jan-auer requested review from RaduW and a team July 8, 2020 10:05
@jan-auer jan-auer self-assigned this Jul 8, 2020
RaduW
RaduW approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@RaduW RaduW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@jan-auer jan-auer merged commit 7570ba0 into master Jul 8, 2020
@jan-auer jan-auer deleted the fix/outcomes-forwarding-internal branch July 8, 2020 12:27
jan-auer added a commit that referenced this pull request Jul 8, 2020
@jan-auer
Merge branch 'master' into chore/try-auto-n
3571714 
* master:
  fix(server): Forward outcomes in processing mode (#653)
  feat(py): Expose DataCategory via C-ABI (#651)
  build: Update backtrace-rs (#652)
  fix(unreal): Do not serialize broken misc_primary_cpu_brand (#650)
jan-auer added a commit that referenced this pull request Jul 8, 2020
@jan-auer
Merge branch 'master' into fix/future-timestamp
5b92cc9 
* master:
  fix(server): Forward outcomes in processing mode (#653)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaduW RaduW RaduW approved these changes

@untitaker untitaker untitaker approved these changes

Assignees

@jan-auer jan-auer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jan-auer @untitaker @RaduW