feat(kafka): Report producer errors #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
reviewed
Jul 24, 2020
jan-auer
approved these changes
Jul 24, 2020
relay-server/src/utils/kafka.rs
Outdated
| type DeliveryOpaque = (); | ||
| fn delivery(&self, result: &DeliveryResult, _delivery_opaque: Self::DeliveryOpaque) { | ||
| if let Err((error, _message)) = result { | ||
| log::error!("callback producer error: {}", LogError(error)); |
There was a problem hiding this comment.
nit: Since this is logged in Sentry, maybe make this more verbose?
Suggested change
| log::error!("callback producer error: {}", LogError(error)); | |
| log::error!("failed to produce message to kafka: {}", LogError(error)); |
There was a problem hiding this comment.
Makes sense, but I think we should include a hint that this callback was triggered asynchronously. What do you think about now?
There was a problem hiding this comment.
Ah, missed your question earlier. Yeah, looks good now!
untitaker
approved these changes
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, asynchronous errors (those happening after the event was queued) in the kafka producer are silently dropped. With this change, the goal is to report those errors to Sentry (or at least write them in the logs).