Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta(gh): Add a status check for changelogs #700

Merged
merged 23 commits into from
Aug 18, 2020
+42 −0
Merged

meta(gh): Add a status check for changelogs #700

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
17838a1
ci: Try out dangerjs
untitaker Jul 31, 2020
40836e7
use yarn?????????????????????????????????????
untitaker Jul 31, 2020
0eef9f1
nodejs 12
untitaker Jul 31, 2020
8519493
add changelog logic
untitaker Jul 31, 2020
2417532
is actually js
untitaker Jul 31, 2020
3b41bfb
grr
untitaker Jul 31, 2020
67bf64d
its ts
untitaker Jul 31, 2020
c6dc92f
clarify msg
untitaker Jul 31, 2020
8b57f30
fix syntax error
untitaker Jul 31, 2020
33486d7
fix another syntax error
untitaker Jul 31, 2020
ef907a5
remove unused imports
untitaker Aug 1, 2020
d2ce4de
just avoid typescript and es6, idk how to make this work
untitaker Aug 1, 2020
a0f70fb
move to github actions
untitaker Aug 17, 2020
fce6979
noop for bot
untitaker Aug 17, 2020
925230b
ref: Fix workflow file
jan-auer Aug 18, 2020
8488909
ref: Upgrade to newer danger-js
jan-auer Aug 18, 2020
520884a
ref: Switch to npx
jan-auer Aug 18, 2020
b358bbe
ref: Update the message
jan-auer Aug 18, 2020
0f72eab
fix: JavaScript syntax
jan-auer Aug 18, 2020
daedbfd
fix: Use correct functions
jan-auer Aug 18, 2020
3b66736
ref: Tweak the message
jan-auer Aug 18, 2020
a07c21b
ref: Add a success message
jan-auer Aug 18, 2020
d1661d1
ref: Run when edited
jan-auer Aug 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: JavaScript syntax
@jan-auer
jan-auer committed Aug 18, 2020
commit 0f72eab000997aa3f4dff118bde908cd30de6bc5
4 changes: 2 additions & 2 deletions dangerfile.js
View file
Original file line number Diff line number Diff line change
@@ -5,9 +5,9 @@ const hasPyChangelog = files.indexOf("py/CHANGELOG.md") !== -1;
const ERROR_MESSAGE = `
Please consider adding a changelog entry for the next release:

For changes exposed to the Python package, please add an entry to ``py/CHANGELOG.md``. This includes, but is not limited to event normalization, PII scrubbing, and the protocol.
For changes exposed to the Python package, please add an entry to \`py/CHANGELOG.md\`. This includes, but is not limited to event normalization, PII scrubbing, and the protocol.

For changes to the Relay server, please add an entry to ``CHANGELOG.md``:
For changes to the Relay server, please add an entry to \`CHANGELOG.md\`:
1. For new user-visible functionality under "Features"
2. For user-visible bug fixes under "Bug Fixes"
3. For features and bug fixes for internal operation (including processing mode) under "Internal"