Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta(gh): Add a status check for changelogs #700

Merged
merged 23 commits into from
Aug 18, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: JavaScript syntax
jan-auer committed Aug 18, 2020
commit 0f72eab000997aa3f4dff118bde908cd30de6bc5
4 changes: 2 additions & 2 deletions dangerfile.js
Original file line number Diff line number Diff line change
@@ -5,9 +5,9 @@ const hasPyChangelog = files.indexOf("py/CHANGELOG.md") !== -1;
const ERROR_MESSAGE = `
Please consider adding a changelog entry for the next release:

For changes exposed to the Python package, please add an entry to ``py/CHANGELOG.md``. This includes, but is not limited to event normalization, PII scrubbing, and the protocol.
For changes exposed to the Python package, please add an entry to \`py/CHANGELOG.md\`. This includes, but is not limited to event normalization, PII scrubbing, and the protocol.

For changes to the Relay server, please add an entry to ``CHANGELOG.md``:
For changes to the Relay server, please add an entry to \`CHANGELOG.md\`:
1. For new user-visible functionality under "Features"
2. For user-visible bug fixes under "Bug Fixes"
3. For features and bug fixes for internal operation (including processing mode) under "Internal"