fix(perf): Improve performance of event processing by avoiding regex clone #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We clone the regex field for newtypes as we inherit the parent processing state. That is very expensive. We could just use Arc here, but we could also just make FieldAttrs Copy again like Armin had it from the start, and build up a map of regexes someplace else. I think I didn't know how to write Rust when I introduced the newtypes behavior.
untitaker
changed the title
mitsuhiko
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We clone the regex field for newtypes as we inherit the parent
processing state. That is very expensive.
We could just use Arc here, but we could also just make FieldAttrs Copy
again like Armin had it from the start, and build up a map of regexes
someplace else.
I think I didn't know how to write Rust when I introduced the newtypes
behavior.