Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(setup): Log when reporting to Sentry is disabled #779

Merged
merged 1 commit into from
Sep 17, 2020
Merged

fix(setup): Log when reporting to Sentry is disabled #779

merged 1 commit into from
Sep 17, 2020

Conversation

jan-auer
Copy link
Member

The logging integration of Sentry SDK 0.19 and 0.20 supresses log messages
when the client is disabled, for instance if the DSN is set to None. Since
this is the default configuration of Relay, logs no longer print to standard
error by default.

This PR skips initializing the Sentry SDK if error reporting is disabled and
instead registers the logger directly.

#skip-changelog

@jan-auer jan-auer requested a review from a team September 17, 2020 16:53
@jan-auer jan-auer self-assigned this Sep 17, 2020
@jan-auer jan-auer mentioned this pull request Sep 17, 2020
Merged
13 tasks
@jan-auer jan-auer merged commit bc598d0 into master Sep 17, 2020
@jan-auer jan-auer deleted the fix/logger-sentry-disabled branch September 17, 2020 17:16
jan-auer added a commit that referenced this pull request Sep 21, 2020
@jan-auer
Merge branch 'master' into feat/redirect-dsn
b3d44a1 
* master:
  feat: Scrubbing of UTF-16 strings in minidumps (#742)
  meta: Update CI badges (#782)
  fix(pii): Fix issue where `$span` would not be recognized in Advanced Data Scrubbing (#781)
  ci: Port CI to GitHub Actions (#780)
  fix(setup): Log when reporting to Sentry is disabled (#779)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@untitaker untitaker untitaker approved these changes

Assignees

@jan-auer jan-auer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jan-auer @untitaker