Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(quotas): Apply GRACE only to redis TTL, not the actual retry-after #829

Merged
merged 3 commits into from
Nov 2, 2020
Merged

fix(quotas): Apply GRACE only to redis TTL, not the actual retry-after #829

merged 3 commits into from
Nov 2, 2020

Conversation

untitaker
Copy link
Member

@untitaker untitaker commented Nov 2, 2020 •
edited
Loading

See original Python code, where grace has only been added for some invocations of get_next_period_start.

This bug was introduced during the first port, not jan's refactor.

https://github.com/getsentry/sentry/blob/28d497fb8af6cc3efbe160e28c1c08f08bd688fc/src/sentry/quotas/redis.py#L199

@untitaker untitaker requested a review from a team November 2, 2020 15:21
jan-auer
jan-auer approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@jan-auer jan-auer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Before merging this, can we check that this (roughly) matches what old Sentry code used to do? My guess is that I made a mistake when refactoring this code.

@untitaker untitaker merged commit 8a4f62d into master Nov 2, 2020
@untitaker untitaker deleted the fix/rate-limit-grace branch November 2, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-auer jan-auer jan-auer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@untitaker @jan-auer