-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol): Add protocol support for WASM #852
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2f9a023
feat(protocol): Add protocol support for WASM
mitsuhiko a5b6d70
ref: in_image -> addr_mode
mitsuhiko c4b7832
ref: Update schema
mitsuhiko 6cf76cb
fix: clippy
mitsuhiko 8a822f3
fix: changelog
mitsuhiko fa0ff77
Merge branch 'master' into feature/wasm
mitsuhiko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -126,6 +126,9 @@ pub struct Frame { | |
/// then symbolication can take place. | ||
pub instruction_addr: Annotated<Addr>, | ||
|
||
/// Defines the addressing mode for addresses. | ||
pub addr_mode: Annotated<String>, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should consider validating the format here, but I think it's fine to merge as string. |
||
|
||
/// (C/C++/Native) Start address of the frame's function. | ||
/// | ||
/// We use the instruction address for symbolication, but this can be used to calculate | ||
|
@@ -361,6 +364,7 @@ fn test_frame_roundtrip() { | |
}, | ||
"image_addr": "0x400", | ||
"instruction_addr": "0x404", | ||
"addr_mode": "abs", | ||
"symbol_addr": "0x404", | ||
"trust": "69", | ||
"lang": "rust", | ||
|
@@ -395,6 +399,7 @@ fn test_frame_roundtrip() { | |
}), | ||
image_addr: Annotated::new(Addr(0x400)), | ||
instruction_addr: Annotated::new(Addr(0x404)), | ||
addr_mode: Annotated::new("abs".into()), | ||
symbol_addr: Annotated::new(Addr(0x404)), | ||
trust: Annotated::new("69".into()), | ||
lang: Annotated::new("rust".into()), | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work with the sentry processor as is? I think we may expect non-null values at some places in
native/processing.py
ornative/symbolicator.py
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked into this, and it will work. There are two places in AppleCrashReport rendering where we would throw None
ValueError
s.