fix(server): Normalize user reports during ingestion #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
approved these changes
Jan 8, 2021
relay-server/src/actors/events.rs
Outdated
|
|
||
| let json_string = match serde_json::to_string(&report) { | ||
| Ok(json) => json, | ||
| Err(_) => return false, |
There was a problem hiding this comment.
I would also log this under a distinct error message, serialization error is more fatal than deserialization error.
There was a problem hiding this comment.
👍 can do, and will also add it to sessions. This falls under should-never-happen.
jan-auer
added a commit
that referenced
this pull request
Jan 13, 2021
* master: fix(server): Normalize user reports during ingestion (#903)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sentry requires that user reports always have a non-null email, name, and
comments. This ensures that we create these fields with empty strings if they
are missing or
null.