ref: Remove Compatibility mode for Session Aggregates #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compatibility mode was added in #815 because it was waiting on proper support in snuba. That downstream support was added recently in getsentry/snuba#1492, and compatibility mode was switched off in production via a configuration change. Also, the snuba change was included in the 21.1 CalVer release, so it is fine to remove compatibility mode and ship this feature in full fidelity in 21.2.
jan-auer
approved these changes
Jan 20, 2021
CHANGELOG.md
Outdated
| @@ -1,12 +1,17 @@ | |||
| # Changelog | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| **Features**: | |||
There was a problem hiding this comment.
Suggested change
| **Features**: | |
| **Internal**: |
jan-auer
added a commit
that referenced
this pull request
Jan 27, 2021
* master: fix: Build proper 64-bit Linux wheel release: 0.8.2 chore: Switch to manylinux2010 (#917) meta(py): Changelog for 0.8.2 ci: Add an action to release the library (#916) ref: Remove Compatibility mode for Session Aggregates (#913) release: 21.1.0 ci: Fix clippy command invocation ci: Run clippy via the cargo action feat(server): Ingest and normalize sample rates (#910)
jan-auer
added a commit
that referenced
this pull request
Jan 28, 2021
* master: fix(server): Log when recovering from network outages (#918) feat: Add a .no-cache option to event sending (#911) fix: Build proper 64-bit Linux wheel release: 0.8.2 chore: Switch to manylinux2010 (#917) meta(py): Changelog for 0.8.2 ci: Add an action to release the library (#916) ref: Remove Compatibility mode for Session Aggregates (#913)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compatibility mode was added in #815 because it was waiting on proper support in snuba.
That downstream support was added recently in getsentry/snuba#1492, and compatibility mode was switched off in production via a configuration change.
Also, the snuba change was included in the 21.1 CalVer release, so it is fine to remove compatibility mode and ship this feature in full fidelity in 21.2.