Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(breakdowns): All fields in breakdown config should be camelCase #993

Merged
merged 4 commits into from
May 14, 2021
Merged

ref(breakdowns): All fields in breakdown config should be camelCase #993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4e9a94b
ref(breakdowns): Rename all fields in SpanOperationsConfig struct to …
dashed May 11, 2021
62761e8
add alias for span_operations
dashed May 13, 2021
92acd57
update changelog
dashed May 13, 2021
984556b
fmt
dashed May 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
- Update internal representation of distribution metrics. ([#979](https://github.com/getsentry/relay/pull/979))
- Extract metrics for transaction breakdowns and sessions when the feature is enabled for the organizaiton. ([#986](https://github.com/getsentry/relay/pull/986))
- Assign explicit values to DataCategory enum. ([#987](https://github.com/getsentry/relay/pull/987))
- All fields in breakdown config should be camelCase. ([#993](https://github.com/getsentry/relay/pull/993))

## 21.4.1

Expand Down
5 changes: 3 additions & 2 deletions relay-general/src/store/normalize/breakdowns.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ pub trait EmitBreakdowns {

/// Configuration to define breakdowns based on span operation name.
#[derive(Debug, Clone, Serialize, Deserialize)]
#[serde(rename_all = "snake_case")]
#[serde(rename_all = "camelCase")]
pub struct SpanOperationsConfig {
/// Operation names are matched against an array of strings. The match is successful if the span
/// operation name starts with any string in the array. If any string in the array has at least
Expand Down Expand Up @@ -202,8 +202,9 @@ impl EmitBreakdowns for SpanOperationsConfig {

/// Configuration to define breakdown to be generated based on properties and breakdown type.
#[derive(Debug, Clone, Serialize, Deserialize)]
#[serde(tag = "type", rename_all = "snake_case")]
#[serde(tag = "type", rename_all = "camelCase")]
pub enum BreakdownConfig {
#[serde(alias = "span_operations")]
SpanOperations(SpanOperationsConfig),
}

Expand Down
2 changes: 1 addition & 1 deletion tests/integration/test_envelope.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ def test_ops_breakdowns(mini_sentry, relay_with_processing, transactions_consume
"matches": ["http", "db", "browser", "resource"],
},
"span_ops_2": {
"type": "span_operations",
"type": "spanOperations",
"matches": ["http", "db", "browser", "resource"],
},
},
Expand Down