upstream: Feat: Add support for replaying :defined pseudo-class of cu…

…stom elements (rrweb-io#1155) (#138) cherry-picks rrweb-io#1155 which was merged in our fork in #107 (prior to rrweb-io#1155 being merged). This results in only 2 small stylistic changes. Feat: Add support for replaying :defined pseudo-class of custom elements rrweb-io#1155 Co-authored-by: Yun Feng <yun.feng0817@gmail.com> Co-authored-by: Nafees Nehar <nafees87n@gmail.com> Co-authored-by: Justin Halsall <Juice10@users.noreply.github.com>
getsentry · Jan 31, 2024 · 120e802 · 120e802
1 parent 403640b
commit 120e802
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/packages/rrweb/src/record/iframe-manager.ts b/packages/rrweb/src/record/iframe-manager.ts
@@ -271,7 +271,6 @@ export class IframeManager implements IframeManagerInterface {
         }
       }
     }
-
     return false;
   }
 

diff --git a/packages/rrweb/src/record/observer.ts b/packages/rrweb/src/record/observer.ts
@@ -1242,12 +1242,8 @@ function initCustomElementObserver({
   customElementCb,
 }: observerParam): listenerHandler {
   const win = doc.defaultView as IWindow;
-  if (!win || !win.customElements) {
-    return () => {
-      // do nothing
-    };
-  }
-
+  // eslint-disable-next-line @typescript-eslint/no-empty-function
+  if (!win || !win.customElements) return () => {};
   const restoreHandler = patch(
     win.customElements,
     'define',
-Original file line number
+Diff line change
@@ Expand Up @@
             }
           }
         }
         return false;
       }
@@ Expand Down @@