Return early for child same origin frames (rrweb-io#1295)

getsentry · May 29, 2024 · d7cf8dd · d7cf8dd
1 parent 4014305
commit d7cf8dd
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/.changeset/silent-plants-perform.md b/.changeset/silent-plants-perform.md
@@ -0,0 +1,5 @@
+---
+'rrweb': patch
+---
+
+Return early for child same origin frames
diff --git a/packages/rrweb/src/record/index.ts b/packages/rrweb/src/record/index.ts
@@ -122,6 +122,11 @@ function record<T = eventWithTime>(
   if (inEmittingFrame && !emit) {
     throw new Error('emit function is required');
   }
+  if (!inEmittingFrame && !passEmitsToParent) {
+    return () => {
+      /* no-op since in this case we don't need to record anything from this frame in particular */
+    };
+  }
   // move departed options to new options
   if (mousemoveWait !== undefined && sampling.mousemove === undefined) {
     sampling.mousemove = mousemoveWait;