Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add build flags to allow noop iframe/canvas/shadow dom managers #114

Merged
merged 3 commits into from
Oct 18, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 31 additions & 1 deletion packages/rrweb/src/record/iframe-manager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,37 @@ import type {
} from '@sentry-internal/rrweb-types';
import type { StylesheetManager } from './stylesheet-manager';

export class IframeManager {
export interface IframeManagerInterface {
crossOriginIframeMirror: CrossOriginIframeMirror;
crossOriginIframeStyleMirror: CrossOriginIframeMirror;
crossOriginIframeRootIdMap: WeakMap<HTMLIFrameElement, number>;

addIframe(iframeEl: HTMLIFrameElement): void;
addLoadListener(cb: (iframeEl: HTMLIFrameElement) => unknown): void;
attachIframe(
iframeEl: HTMLIFrameElement,
childSn: serializedNodeWithId,
): void;
}

export class IframeManagerNoop implements IframeManagerInterface {
public crossOriginIframeMirror = new CrossOriginIframeMirror(genId);
public crossOriginIframeStyleMirror: CrossOriginIframeMirror;
public crossOriginIframeRootIdMap: WeakMap<HTMLIFrameElement, number> =
new WeakMap();

public addIframe() {
// noop
}
public addLoadListener() {
// noop
}
public attachIframe() {
// noop
}
}

export class IframeManager implements IframeManagerInterface {
private iframes: WeakMap<HTMLIFrameElement, true> = new WeakMap();
private crossOriginIframeMap: WeakMap<MessageEventSource, HTMLIFrameElement> =
new WeakMap();
Expand Down
131 changes: 78 additions & 53 deletions packages/rrweb/src/record/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,21 @@
adoptedStyleSheetParam,
} from '@sentry-internal/rrweb-types';
import type { CrossOriginIframeMessageEventContent } from '../types';
import { IframeManager } from './iframe-manager';
import { ShadowDomManager } from './shadow-dom-manager';
import { CanvasManager } from './observers/canvas/canvas-manager';
import {
IframeManager,
IframeManagerInterface,
IframeManagerNoop,
} from './iframe-manager';
import {
ShadowDomManager,
ShadowDomManagerInterface,
ShadowDomManagerNoop,
} from './shadow-dom-manager';
import {
CanvasManager,
CanvasManagerInterface,
CanvasManagerNoop,
} from './observers/canvas/canvas-manager';
import { StylesheetManager } from './stylesheet-manager';
import ProcessedNodeManager from './processed-node-manager';
import {
Expand All @@ -47,10 +59,16 @@
};
}

declare global {
const __RRWEB_EXCLUDE_CANVAS__: boolean;
const __RRWEB_EXCLUDE_SHADOW_DOM__: boolean;
const __RRWEB_EXCLUDE_IFRAME__: boolean;
}

let wrappedEmit!: (e: eventWithTime, isCheckout?: boolean) => void;

let takeFullSnapshot!: (isCheckout?: boolean) => void;
let canvasManager!: CanvasManager;
let canvasManager: CanvasManagerInterface;
let recording = false;

const mirror = createMirror();
Expand Down Expand Up @@ -291,13 +309,15 @@
adoptedStyleSheetCb: wrappedAdoptedStyleSheetEmit,
});

const iframeManager = new IframeManager({
mirror,
mutationCb: wrappedMutationEmit,
stylesheetManager: stylesheetManager,
recordCrossOriginIframes,
wrappedEmit,
});
const iframeManager: IframeManagerInterface = __RRWEB_EXCLUDE_IFRAME__
mydea marked this conversation as resolved.
Show resolved Hide resolved
? new IframeManagerNoop()
: new IframeManager({
mirror,
mutationCb: wrappedMutationEmit,
stylesheetManager: stylesheetManager,
recordCrossOriginIframes,
wrappedEmit,
});

/**
* Exposes mirror to the plugins
Expand All @@ -314,49 +334,54 @@

const processedNodeManager = new ProcessedNodeManager();

canvasManager = new CanvasManager({
recordCanvas,
mutationCb: wrappedCanvasMutationEmit,
win: window,
blockClass,
blockSelector,
unblockSelector,
mirror,
sampling: sampling.canvas,
dataURLOptions,
});
canvasManager = __RRWEB_EXCLUDE_CANVAS__
? new CanvasManagerNoop()
: new CanvasManager({
recordCanvas,
mutationCb: wrappedCanvasMutationEmit,
win: window,
blockClass,
blockSelector,
unblockSelector,
mirror,
sampling: sampling.canvas,
dataURLOptions,
});

const shadowDomManager = new ShadowDomManager({
mutationCb: wrappedMutationEmit,
scrollCb: wrappedScrollEmit,
bypassOptions: {
onMutation,
blockClass,
blockSelector,
unblockSelector,
maskAllText,
maskTextClass,
unmaskTextClass,
maskTextSelector,
unmaskTextSelector,
inlineStylesheet,
maskInputOptions,
dataURLOptions,
maskAttributeFn,
maskTextFn,
maskInputFn,
recordCanvas,
inlineImages,
sampling,
slimDOMOptions,
iframeManager,
stylesheetManager,
canvasManager,
keepIframeSrcFn,
processedNodeManager,
},
mirror,
});
const shadowDomManager: ShadowDomManagerInterface =
__RRWEB_EXCLUDE_SHADOW_DOM__
? new ShadowDomManagerNoop()
: new ShadowDomManager({
mutationCb: wrappedMutationEmit,
scrollCb: wrappedScrollEmit,
bypassOptions: {
onMutation,
blockClass,
blockSelector,
unblockSelector,
maskAllText,
maskTextClass,
unmaskTextClass,
maskTextSelector,
unmaskTextSelector,
inlineStylesheet,
maskInputOptions,
dataURLOptions,
maskAttributeFn,
maskTextFn,
maskInputFn,
recordCanvas,
inlineImages,
sampling,
slimDOMOptions,
iframeManager,
stylesheetManager,
canvasManager,
keepIframeSrcFn,
processedNodeManager,
},
mirror,
});

takeFullSnapshot = (isCheckout = false) => {
wrappedEmit(
Expand Down Expand Up @@ -588,7 +613,7 @@
plugins
?.filter((p) => p.observer)
?.map((p) => ({
observer: p.observer!,

Check warning on line 616 in packages/rrweb/src/record/index.ts

View workflow job for this annotation

GitHub Actions / ESLint Report Analysis

packages/rrweb/src/record/index.ts#L616

[@typescript-eslint/no-non-null-assertion] Forbidden non-null assertion.
options: p.options,
callback: (payload: object) =>
wrappedEmit(
Expand All @@ -608,7 +633,7 @@

iframeManager.addLoadListener((iframeEl) => {
try {
handlers.push(observe(iframeEl.contentDocument!));

Check warning on line 636 in packages/rrweb/src/record/index.ts

View workflow job for this annotation

GitHub Actions / ESLint Report Analysis

packages/rrweb/src/record/index.ts#L636

[@typescript-eslint/no-non-null-assertion] Forbidden non-null assertion.
} catch (error) {
// TODO: handle internal error
console.warn(error);
Expand Down
28 changes: 27 additions & 1 deletion packages/rrweb/src/record/observers/canvas/canvas-manager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,33 @@
canvasMutationWithType[]
>;

export class CanvasManager {
export interface CanvasManagerInterface {
reset(): void;
freeze(): void;
unfreeze(): void;
lock(): void;
unlock(): void;
}

export class CanvasManagerNoop implements CanvasManagerInterface {
public reset() {
// noop
}
public freeze() {
// noop
}
public unfreeze() {
// noop
}
public lock() {
// noop
}
public unlock() {
// noop
}
}

export class CanvasManager implements CanvasManagerInterface {
private pendingCanvasMutations: pendingCanvasMutationsMap = new Map();
private rafStamps: RafStamps = { latestId: 0, invokeId: null };
private mirror: Mirror;
Expand Down Expand Up @@ -116,7 +142,7 @@
this.pendingCanvasMutations.set(target, []);
}

this.pendingCanvasMutations.get(target)!.push(mutation);

Check warning on line 145 in packages/rrweb/src/record/observers/canvas/canvas-manager.ts

View workflow job for this annotation

GitHub Actions / ESLint Report Analysis

packages/rrweb/src/record/observers/canvas/canvas-manager.ts#L145

[@typescript-eslint/no-non-null-assertion] Forbidden non-null assertion.
};

private initCanvasFPSObserver(
Expand Down Expand Up @@ -323,7 +349,7 @@
if (!valuesWithType || id === -1) return;

const values = valuesWithType.map((value) => {
const { type, ...rest } = value;

Check warning on line 352 in packages/rrweb/src/record/observers/canvas/canvas-manager.ts

View workflow job for this annotation

GitHub Actions / ESLint Report Analysis

packages/rrweb/src/record/observers/canvas/canvas-manager.ts#L352

[@typescript-eslint/no-unused-vars] 'type' is assigned a value but never used.
return rest;
});
const { type } = valuesWithType[0];
Expand Down
24 changes: 23 additions & 1 deletion packages/rrweb/src/record/shadow-dom-manager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,29 @@ type BypassOptions = Omit<
sampling: SamplingStrategy;
};

export class ShadowDomManager {
export interface ShadowDomManagerInterface {
init(): void;
addShadowRoot(shadowRoot: ShadowRoot, doc: Document): void;
observeAttachShadow(iframeElement: HTMLIFrameElement): void;
reset(): void;
}

export class ShadowDomManagerNoop implements ShadowDomManagerInterface {
public init() {
// noop
}
public addShadowRoot() {
// noop
}
public observeAttachShadow() {
// noop
}
public reset() {
// noop
}
}

export class ShadowDomManager implements ShadowDomManagerInterface {
private shadowDoms = new WeakSet<ShadowRoot>();
private mutationCb: mutationCallBack;
private scrollCb: scrollCallback;
Expand Down
21 changes: 15 additions & 6 deletions packages/rrweb/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,20 @@
MaskAttributeFn,
} from '@sentry-internal/rrweb-snapshot';
import type { PackFn, UnpackFn } from './packer/base';
import type { IframeManager } from './record/iframe-manager';
import type { ShadowDomManager } from './record/shadow-dom-manager';
import type {
IframeManager,

Check warning on line 12 in packages/rrweb/src/types.ts

View workflow job for this annotation

GitHub Actions / ESLint Report Analysis

packages/rrweb/src/types.ts#L12

[@typescript-eslint/no-unused-vars] 'IframeManager' is defined but never used.
IframeManagerInterface,
} from './record/iframe-manager';
import type {
ShadowDomManager,

Check warning on line 16 in packages/rrweb/src/types.ts

View workflow job for this annotation

GitHub Actions / ESLint Report Analysis

packages/rrweb/src/types.ts#L16

[@typescript-eslint/no-unused-vars] 'ShadowDomManager' is defined but never used.
ShadowDomManagerInterface,
} from './record/shadow-dom-manager';
import type { Replayer } from './replay';
import type { RRNode } from '@sentry-internal/rrdom';
import type { CanvasManager } from './record/observers/canvas/canvas-manager';
import type {
CanvasManager,

Check warning on line 22 in packages/rrweb/src/types.ts

View workflow job for this annotation

GitHub Actions / ESLint Report Analysis

packages/rrweb/src/types.ts#L22

[@typescript-eslint/no-unused-vars] 'CanvasManager' is defined but never used.
CanvasManagerInterface,
} from './record/observers/canvas/canvas-manager';
import type { StylesheetManager } from './record/stylesheet-manager';
import type {
addedNodeMutation,
Expand Down Expand Up @@ -122,10 +131,10 @@
dataURLOptions: DataURLOptions;
doc: Document;
mirror: Mirror;
iframeManager: IframeManager;
iframeManager: IframeManagerInterface;
stylesheetManager: StylesheetManager;
shadowDomManager: ShadowDomManager;
canvasManager: CanvasManager;
shadowDomManager: ShadowDomManagerInterface;
canvasManager: CanvasManagerInterface;
processedNodeManager: ProcessedNodeManager;
ignoreCSSAttributes: Set<string>;
plugins: Array<{
Expand Down
Loading