Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add size limit action #127

Merged
merged 5 commits into from
Oct 25, 2023
Merged

build: Add size limit action #127

merged 5 commits into from
Oct 25, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Oct 25, 2023

Add action for size limit info, similar to the sentry-javascript repo.

This should make it much easier to check the impact of changes.

@mydea mydea requested a review from billyvg October 25, 2023 12:46
@mydea mydea self-assigned this Oct 25, 2023
@github-actions
Copy link

github-actions bot commented Oct 25, 2023

size-limit report 📦

Path Size
rrweb - record only (gzipped) 23.05 KB (added)
rrweb - record only (min) 80.78 KB (added)
rrweb - record with treeshaking flags (gzipped) 15.85 KB (added)

Comment on lines +3 to +14
{
name: 'rrweb - record only (gzipped)',
path: 'packages/rrweb/es/rrweb/packages/rrweb/src/entries/all.js',
import: '{ record }',
gzip: true
},
{
name: 'rrweb - record only (min)',
path: 'packages/rrweb/es/rrweb/packages/rrweb/src/entries/all.js',
import: '{ record }',
gzip: false
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you swap the ordering for these two?

@mydea mydea merged commit 66d7f91 into sentry-v2 Oct 25, 2023
@mydea mydea deleted the fn/bundle-size branch October 25, 2023 15:22
billyvg pushed a commit that referenced this pull request Apr 26, 2024
Add action for size limit info, similar to the sentry-javascript repo.

This should make it much easier to check the impact of changes.

---------

Co-authored-by: mydea <mydea@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants