Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(canvas): Bind mutationCb outside of getCanvasManager #141

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Dec 14, 2023

From what I can tell, record ends up getting bundled separate from getCanvasManager in user-land code and canvas mutation events end up not being transmitted because _wrappedEmit does not get set and it will hold the wrong mirror reference.

From what I can tell, `record` ends up getting bundled separate from `getCanvasManager` in user-land code and canvas mutation events end up not being transmitted.
Copy link

github-actions bot commented Dec 14, 2023

size-limit report 📦

Path Size
rrweb - record only (gzipped) 16.84 KB (+0.37% 🔺)
rrweb - record & getCanvasManager only (gzipped) 22.92 KB (+0.01% 🔺)
rrweb - record only (min) 57.94 KB (+0.37% 🔺)
rrweb - record with treeshaking flags (gzipped) 15.59 KB (+0.29% 🔺)

@billyvg billyvg marked this pull request as ready for review December 14, 2023 14:49
@billyvg billyvg merged commit bfbf35a into sentry-v2 Dec 14, 2023
14 checks passed
@billyvg billyvg deleted the feat-bind-emit-outside-of-get-canvas-manager branch December 14, 2023 14:51
billyvg added a commit that referenced this pull request Apr 26, 2024
From what I can tell, `record` ends up getting bundled separate from
`getCanvasManager` in user-land code and canvas mutation events end up
not being transmitted because `_wrappedEmit` does not get set and it
will hold the wrong `mirror` reference.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants