feat: Remove getCanvasManager, export CanvasManager class directly
#153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies the code a bit by exporting the CanvasManager directly. With [ReplayCanvas](getsentry/sentry-javascript#10112), we can rely on it for complex setup, but keeps it simple for our users.
This simplifies the code a bit by exporting the CanvasManager directly. With [ReplayCanvas](getsentry/sentry-javascript#10112), we can rely on it for complex setup, but keeps it simple for our users.
billyvg
force-pushed
the
feat-fix-tree-shaking-canvas-manager
branch
from
5c0484b to
9021d0d
Compare
c298lee
approved these changes
Jan 9, 2024
size-limit report 📦
|
|
hmm if this does not mess with tree shaking (always hard to say in this code base 😬 ) then looks good to me! |
mydea
approved these changes
Jan 10, 2024
|
Seems like tree shaking still works according to size-limit! |
billyvg
added a commit
that referenced
this pull request
Apr 26, 2024
#153) This simplifies the code a bit by exporting the CanvasManager directly. With [ReplayCanvas](getsentry/sentry-javascript#10112), we can rely on it for complex setup, but keeps it simple for our users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the code a bit by exporting the CanvasManager directly. With ReplayCanvas, we can rely on it for complex setup, but keeps it simple for our users.