feat: Enforce masking of credit card fields #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
billyvg
approved these changes
Feb 1, 2024
mydea
force-pushed
the
fn/disallow-cc-autocomplete
branch
from
7d782e9 to
42e28c3
Compare
|
@billyvg added another test here in rrweb that tests this "in-depth", both adding new elements, changing their values etc. |
billyvg
approved these changes
Feb 1, 2024
billyvg
pushed a commit
that referenced
this pull request
Apr 26, 2024
This is on top of #165, actually fixing the behavior so that certain fields cannot be unmasked. This is a pretty straightforward fix, a bit "hacky" but should work well enough. Fixes getsentry/sentry-javascript#10258 --------- Co-authored-by: mydea <mydea@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of #165, actually fixing the behavior so that certain fields cannot be unmasked.
This is a pretty straightforward fix, a bit "hacky" but should work well enough.
Fixes getsentry/sentry-javascript#10258