Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstream: perf: only call createHTMLDocument where it is needed #179

Merged

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Apr 19, 2024

  • only call createHTMLDocument where it is needed

  • Perf: create the mutation document once as a 'singleton' as it can be reused


Co-authored-by: Michael Dellanoce mdellanoce@pendo.io

* only call createHTMLDocument where it is needed

* Perf: create the mutation document once as a 'singleton' as it can be reused

---------

Co-authored-by: Michael Dellanoce <mdellanoce@pendo.io>
@billyvg billyvg changed the title Md create html document (#1321) upstream: perf: only call createHTMLDocument where it is needed Apr 19, 2024
@billyvg
Copy link
Member Author

billyvg commented Apr 19, 2024

Ref: rrweb-io#1321

Copy link

size-limit report 📦

Path Size
rrweb - record only (gzipped) 16.82 KB (+0.13% 🔺)
rrweb - record & CanvasManager only (gzipped) 19.62 KB (+0.07% 🔺)
rrweb - record only (min) 57.3 KB (+0.11% 🔺)
rrweb - record with treeshaking flags (gzipped) 15.61 KB (+0.07% 🔺)

@billyvg billyvg marked this pull request as ready for review April 19, 2024 14:24
@billyvg billyvg requested a review from a team April 19, 2024 14:24
@billyvg billyvg merged commit 9e07245 into sentry-v2 Apr 19, 2024
14 checks passed
@billyvg billyvg deleted the upstream-dbd15a949263befa8d019fc5f9df8ee967398e0f branch April 19, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants