fix: fix css parsing in replayer #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rweb-io#1431)" This reverts commit a7c33f2.
| '.a:hover, .a.\\:hover { color: white }', | ||
| ); | ||
| }); | ||
|
|
||
| it('can correctly add hover when in middle of selector', () => { |
There was a problem hiding this comment.
why did these (and the other tests) get deleted?
There was a problem hiding this comment.
it was from reverting this commit too: a7c33f2
michellewzhang
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #182 (i.e. we are going back to #169) as we had some performance regressions with the CSS changes.
I tested these against the replays that had crashed with the upstream changes and they seem to work ok.