feat: Fix blocking dynamically added iframes #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug with iframes that are dynamically added to the DOM after the snapshot is taken where it is not being blocked at all. This ensures we check if iframe is considered blocked before adding to iframe manager. Closes getsentry/sentry-javascript#13173
c298lee
approved these changes
Aug 9, 2024
billyvg
commented
Aug 14, 2024
Comment on lines
+13035
to
+13046
| \\"node\\": { | ||
| \\"type\\": 2, | ||
| \\"tagName\\": \\"iframe\\", | ||
| \\"attributes\\": { | ||
| \\"class\\": \\"rr-block\\", | ||
| \\"rr_width\\": \\"104px\\", | ||
| \\"rr_height\\": \\"104px\\" | ||
| }, | ||
| \\"childNodes\\": [], | ||
| \\"id\\": 23 | ||
| } | ||
| }, |
There was a problem hiding this comment.
This is correct as it records the dimensions, but omits the src since it is blocked.
billyvg
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Aug 27, 2024
* [fix(rrdom): Ignore invalid DOM attributes when diffing](getsentry/rrweb#213) * [fix: manual snapshot in rAF loop](getsentry/rrweb#210) (thanks @ShinyChang) * [feat: Fix blocking dynamically added iframes](getsentry/rrweb#212)
billyvg
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Aug 27, 2024
* [fix(rrdom): Ignore invalid DOM attributes when diffing](getsentry/rrweb#213) * [fix: manual snapshot in rAF loop](getsentry/rrweb#210) (thanks @ShinyChang) * [feat: Fix blocking dynamically added iframes](getsentry/rrweb#212)
jakst
added a commit
to jakst/sentry-replay-stripe
that referenced
this pull request
Sep 3, 2024
Upgrade Sentry to v8.28.0 This include rrweb v2.26.0 with getsentry/rrweb#212 which claims to fix getsentry/sentry-javascript#13173
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug with blocking iframes that are dynamically added to the DOM after the snapshot is taken. This ensures we check if iframe is considered blocked before adding to iframe manager.
Closes getsentry/sentry-javascript#13173