fix(snapshot): Set <link> attributes to null for remote CSS
#227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When in-lining CSS for remote CSS, set attributes to `null` instead of deleting the attributes. The former does not generate a mutation for the attributes. Also include `crossorigin` as an attribute to be removed.
c298lee
approved these changes
Dec 9, 2024
billyvg
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Dec 12, 2024
Includes the following fixes: - fix: remote CSS does not get rebuilt properly ([#226](getsentry/rrweb#226)) - fix(snapshot): Set <link> attributes to null for remote CSS ([#227](getsentry/rrweb#227)) - fix(snapshot): Change to ignore all link[rel="modulepreload"] ([#228](getsentry/rrweb#228))
billyvg
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Dec 12, 2024
Includes the following fixes: - fix: remote CSS does not get rebuilt properly ([#226](getsentry/rrweb#226)) - fix(snapshot): Set <link> attributes to null for remote CSS ([#227](getsentry/rrweb#227)) - fix(snapshot): Change to ignore all link[rel="modulepreload"] ([#228](getsentry/rrweb#228))
billyvg
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Dec 12, 2024
Includes the following fixes: - fix: remote CSS does not get rebuilt properly ([#226](getsentry/rrweb#226)) - fix(snapshot): Set <link> attributes to null for remote CSS ([#227](getsentry/rrweb#227)) - fix(snapshot): Change to ignore all link[rel="modulepreload"] ([#228](getsentry/rrweb#228))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When in-lining CSS for remote CSS, set attributes to
nullinstead of deleting the attributes. The former does not generate a mutation for the attributes. Also includecrossoriginas an attribute to be removed.