Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(rrweb): Re-enable skipped test #229

Open
wants to merge 1 commit into
base: sentry-v2
Choose a base branch
from
Open

test(rrweb): Re-enable skipped test #229

wants to merge 1 commit into from

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Dec 13, 2024

Re-enables test that was skipped in #172;

@billyvg
test(rrweb): Re-enable skipped test
ae61ee3 
Re-enables test that was skipped in #172;
@billyvg
Copy link
Member Author

billyvg commented Dec 13, 2024

Closes #172

@billyvg billyvg marked this pull request as ready for review December 13, 2024 18:22
@billyvg billyvg requested review from a team and removed request for a team December 13, 2024 18:22
c298lee
c298lee reviewed Dec 13, 2024
View reviewed changes
Copy link
Member

@c298lee c298lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 is it no longer flakey anymore?

@billyvg
Copy link
Member Author

billyvg commented Dec 13, 2024

I re-ran the test 3 times so far -- will run it a few more times

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c298lee c298lee c298lee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@billyvg @c298lee