fix: Ensure CSS support is checked more robustly #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reference, this is probably fixed here: NV/CSSOM#111 but illustrates how we can't really rely on "this is supported everywhere!" thinking, sadly. |
billyvg
pushed a commit
that referenced
this pull request
Feb 3, 2023
Noticed this while debugging tests in sentry-javascript. it seems jsdom
has a weird support for `CSSMediaRule`, where it is defined but if you
look at `CSSMediaRule.prototype` it is:
```
CSSRule {
parentRule: null,
parentStyleSheet: null,
constructor: [Function: CSSMediaRule],
type: 4
}
```
I guess maybe similar issues have triggered some of the errors we've
seen in the past.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this while debugging tests in sentry-javascript. it seems jsdom has a weird support for
CSSMediaRule, where it is defined but if you look atCSSMediaRule.prototypeit is:I guess maybe similar issues have triggered some of the errors we've seen in the past.
Note: We've been handling these errors already, but still good to fix it properly. I'll also PR this upsteam.