Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: masking inputs on change when maskAllInputs:false #61

Merged
merged 6 commits into from
Feb 24, 2023
Merged

fix: masking inputs on change when maskAllInputs:false #61

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e812910
test: Fix masking inputs on change when `maskAllInputs:false`
billyvg Feb 22, 2023
2ba61fa
refactor utility functions and check if there are masking options inv…
billyvg Feb 23, 2023
f433d2a
undo prettier
billyvg Feb 23, 2023
8aee828
Merge branch 'sentry-v1' into test-mask-all-text-false-input-mutation
billyvg Feb 24, 2023
136c45d
update snapshots, masking fix from a different PR
billyvg Feb 24, 2023
7033081
update types
billyvg Feb 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions packages/rrweb/src/record/observer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,16 +365,12 @@ function initInputObserver({
) {
return;
}

let text = (target as HTMLInputElement).value;
let isChecked = false;
if (type === 'radio' || type === 'checkbox') {
isChecked = (target as HTMLInputElement).checked;
} else if (
maskInputOptions[
(target as Element).tagName.toLowerCase() as keyof MaskInputOptions
] ||
maskInputOptions[type as keyof MaskInputOptions]
) {
} else {
text = maskInputValue({
input: target as HTMLElement,
maskInputOptions,
Expand Down
Loading