fix(build/CI): Run prepublish scripts before building tarballs #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyvg
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, in the "Upload Artifacts" job, we didn't explicitly run a build command but instead relied on the package-specific
prepackyarn scripts. This caused an incomplete@sentry-internal/rrweb-playerpackage, as this package didn't have aprepackscript. This PR now adds a step to the CI job to actually run theprepublishbuild command before packing the tarballs.I checked the resulting tarball against the actual rrweb player and it seems all files are present now. Uploaded artifacts of a test branch: https://github.com/getsentry/rrweb/actions/runs/4263220937
Misc: This PR also updates a type declaration file that was stale beforehand.
closes #63