[feat] Add functionality for AI PR review #1647
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds functionality for 2 endpoints to review a PR using Vertex AI. It leverages similar functionality as the unit test endpoint. `/codegen/pr-review` kicks off a PR review `/codegen/pr-review/state` fetches the stats of a given review `pr_review_step.py` is responsible for fetching a list of json comments for a given PR, and `pr_review_publisher` is responsible for posting comments to that PR. --------- Co-authored-by: Suejung Shin <suejung.shin@sentry.io> Co-authored-by: Jenn Mueng <30991498+jennmueng@users.noreply.github.com>
src/seer/automation/pipeline.py
Outdated
| @@ -68,7 +68,7 @@ class PipelineStep(abc.ABC, Generic[_RequestType, _ContextType]): | |||
|
|
|||
| def __init__(self, request: dict[str, Any]): | |||
| self.request = self._instantiate_request(request) | |||
| self.context = self._instantiate_context(self.request) | |||
| self.context = self._instantiate_context(self.request, DbStateRunTypes.PR_REVIEW) | |||
There was a problem hiding this comment.
Removed keyword here:
Cause of last revert
There was a problem hiding this comment.
hmm is this correct? we'd be defaulting all pipeline contexts to the pr review type including autofix?
There was a problem hiding this comment.
That var is unused in the _instantiate_context method. I can update to autofix for clarity.
There was a problem hiding this comment.
Updated to use None.
You can check autofix\steps\steps.py to verify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality for 2 endpoints to review a PR using Vertex
AI. It leverages similar functionality as the unit test endpoint.
/codegen/pr-reviewkicks off a PR review/codegen/pr-review/statefetches the stats of a given reviewpr_review_step.pyis responsible for fetching a list of json commentsfor a given PR, and
pr_review_publisheris responsible for postingcomments to that PR.