Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset.sh breaking after passing to install.sh during check-minimum-requirements.sh line 3: file not found #1079

Closed
kibble1 opened this issue Aug 27, 2021 · 4 comments

Comments

@kibble1
Copy link

kibble1 commented Aug 27, 2021

Version

nightly

Steps to Reproduce

on an existing onpremise setup run ./reset.sh

after the call to install.sh check-minimum-requirements breaks at line 3: with the call to _min_requirements.sh not found.

seems while running in reset.sh and then calling install.sh the working directory changes to onpremise; however if running strictly in install.sh the working directory is onpremise/install

image

Expected Result

reset.sh and then install.sh should flow correctly

Actual Result

exits with check-minimum-requirements.sh: line 3: /root/onpremise/_min-requirements.sh: No such file or directory

image

@chadwhitacre
Copy link
Member

Confirmed, thanks for the report @kibble1. Glad someone found reset.sh. 😁

@chadwhitacre
Copy link
Member

Probably a regression in #1066, lessee here ...

@chadwhitacre
Copy link
Member

Up for making a PR @kibble1? :) I can get to this in a bit but thought I'd offer ...

@chadwhitacre
Copy link
Member

Figured I'd better 👍 this issue as I just ran into it myself. 😂 😭

chadwhitacre added a commit that referenced this issue Nov 1, 2021
We need $0 to evaluate as install.sh in order for check-requirements to
work.
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants