Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check health of containers in e2e tests #1762

Closed
Tracked by #55
emmatyping opened this issue Oct 17, 2022 · 2 comments · Fixed by #1897
Closed
Tracked by #55

Check health of containers in e2e tests #1762

emmatyping opened this issue Oct 17, 2022 · 2 comments · Fixed by #1897
Assignees

Comments

@emmatyping
Copy link
Contributor

We want to check that all the containers are healthy after we run the event through the test instance - this catches any containers that crash due to an issue at runtime.

Currently we only check container health in the installer.

@BYK
Copy link
Member

BYK commented Oct 19, 2022

Did this actually happen causing a bug getting through? If so I'm willing to submit a PR :)

@emmatyping
Copy link
Contributor Author

Yes, just before the 22.10.0 release, the error and transaction pipelines were split, causing getsentry/sentry#40120

If you would like to submit a PR to add this that would be great, but I think if we are going to centralize our e2e tests (#1756 for anyone reading along) we should probably hold off until that is done first.

@emmatyping emmatyping self-assigned this Jan 3, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants