-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for symbolicator pipeline #1916
Conversation
9c4f415
to
bbeae53
Compare
Passing case. 💃 Let's see it catch a failure! 😁 |
Observation: I don't recall why I opted for using |
@BYK eventually I'd like to rewrite the installer in Python and make it so we can use pytest and all the creature comforts that come from that (probably use playwright in tests as well!). But that is a much larger project 😅 |
Here is a sample of a failure: https://github.com/getsentry/self-hosted/actions/runs/3952966281/jobs/6768689917#step:5:6808 Symbol upload will fail of course, so we fail at the sentry-cli point. EDIT: failing commit now reverted |
This reverts commit b895901.
This is kind of orthogonal to what I'm suggesting though. There's no reason for integration tests to be in the same language or environment with the installer (maybe it was my faulty brain which fell into this misconseption in the first place, don't really remember). We can right now at this moment, start creating Playwright tests and start benefitting from them which would cut through most of this crazy bash/curl/jq dance with CSRF tokens etc. It would:
Regarding rewriting the installer in Python (or any other language tbh), I'd suggest finding ways of getting rid of it completely (such as by adopting Ansible, Helm charts, or whatever). It would be a challenge to use Python unless the installer gets compiled into a self-contained binary for each system by using something like PyOxidizer |
This is a new dependency of the integration tests from getsentry/self-hosted#1916
Also benefiting from #1762: 😁
|
I'm open to Playwright, def separate from installer lang. |
This is true. I am hesitant to start on this since we are near the end of the quarter and I don't want the project delayed much more, but maybe when I add the snuba tests I will add them as playwright tests.
The idea with that was to make the installer run entirely in docker except for a minimal kickoff script. I agree Ansible might be better, but I'm unsure if making that a dependency is acceptable for our users (right now we only require GNU core utils and docker). |
Fixes #1888
This integration test:
uploads a symbol file, which indicates where to find the symbols for the minidump
uploads a sample minidump, which creates an event we can check for
This test is based on the test here: https://github.com/getsentry/sentry/blob/28f4f36b4adc3d39ea80f2f1864cff8e311b6af3/tests/symbolicator/test_minidump_full.py#L72