Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for symbolification pipeline, based on test in Sentry repo #1888

Closed
Tracked by #1761
emmatyping opened this issue Dec 28, 2022 · 0 comments · Fixed by #1916
Closed
Tracked by #1761

Add test for symbolification pipeline, based on test in Sentry repo #1888

emmatyping opened this issue Dec 28, 2022 · 0 comments · Fixed by #1916
Labels
Type: Enhancement

Comments

@emmatyping
Copy link
Contributor

Arpad suggested for testing symbolicator workflows:

That seems like a good idea, yes. To cover this particular usecase, you would need a test that uses all the builtin symbol servers. A Windows minidump perhaps. We should have one already in the main Sentry tests, though those tests are always testing the very latest symbolicator master.

The tests live here: https://github.com/getsentry/sentry/tree/master/tests/symbolicator
@emmatyping emmatyping mentioned this issue Dec 28, 2022
Closed
2 tasks
@emmatyping emmatyping mentioned this issue Jan 17, 2023
Merged
emmatyping added a commit that referenced this issue Jan 19, 2023
@emmatyping
ci: Add test for symbolicator pipeline (#1916)
19d6edf 
Fixes #1888

This integration test:

uploads a symbol file, which indicates where to find the symbols for the minidump
uploads a sample minidump, which creates an event we can check for

This test is based on the test here: https://github.com/getsentry/sentry/blob/28f4f36b4adc3d39ea80f2f1864cff8e311b6af3/tests/symbolicator/test_minidump_full.py#L72
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add test for symbolicator pipeline getsentry/self-hosted
1 participant
@emmatyping