fix(suggested-fix): key should be 'key', not 'token' #2146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It uses new design now (by default, see getsentry/sentry#47531). Here are a few screenshots:
|
BYK
approved these changes
May 16, 2023
There was a problem hiding this comment.
This is why we should have tests 🙂 (not your fault, the repo is not in great shape to add more tests for new features).
Bump on that Playwright patch maybe @chadwhitacre @hubertdeng123 ?
Hrm ... I seem to recall some different approaches to test coverage over the years. 😜 |
chadwhitacre
approved these changes
May 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was upgrading my Sentry instance to the latest version, then I spent like 15 minutes wondering on why the Suggested Fix feature I made the PR of is gone. I thought the Sentry team changed the logic of that. It turns out I made a typo.
This is how I feel right now:
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.