Fix error fingerprinting #2237
Merged
Fix error fingerprinting #2237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadwhitacre
force-pushed
the
cwlw/fix-error-fingerprinting
branch
from
7d0d5e3
to
d9f1ceb
Compare
hubertdeng123
approved these changes
Jun 27, 2023
chadwhitacre
force-pushed
the
cwlw/fix-error-fingerprinting
branch
from
6d1473d
to
53d5358
Compare
21 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we weren't fingerprinting properly. We were sending our custom hash as the
event_idand not as afingerprintarray.